Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test-support/trie-bench test warning #145

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Fixed test-support/trie-bench test warning #145

merged 2 commits into from
Nov 17, 2021

Conversation

red15
Copy link
Contributor

@red15 red15 commented Nov 17, 2021

No description provided.

@ordian ordian merged commit 2e02b09 into paritytech:master Nov 17, 2021
@ordian
Copy link
Member

ordian commented Nov 17, 2021

Thanks!

@red15
Copy link
Contributor Author

red15 commented Nov 18, 2021

@ordian can you verify I've kept the benchmarking solution intact ? I'm not awfully familiar with this project and how/what it is measuring here in this benchmark.

@ordian
Copy link
Member

ordian commented Nov 18, 2021

looks fine

@red15 red15 deleted the criterion_warning_benchmarkgroup branch November 18, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants